-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: optimize informers transformers #1736
Open
dongjiang1989
wants to merge
10
commits into
koordinator-sh:main
Choose a base branch
from
kubeservice-stack:transform-managedfields-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5986173
optimize informers transformers
dongjiang1989 6a0352c
fix license-header-checker
dongjiang1989 1f11ff0
add unittest case
dongjiang1989 c7786e2
update metadata_transformer_test.go
dongjiang1989 4735cb7
Merge branch 'main' into transform-managedfields-cleanup
dongjiang1989 a6fc89d
Merge branch 'main' into transform-managedfields-cleanup
dongjiang1989 6f4f598
Merge branch 'main' into transform-managedfields-cleanup
dongjiang1989 f4337b6
update metadata transformer
dongjiang1989 58125df
Merge branch 'main' into transform-managedfields-cleanup
dongjiang1989 68526fc
Merge branch 'main' into transform-managedfields-cleanup
dongjiang1989 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
/* | ||
Copyright 2022 The Koordinator Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package transformer | ||
|
||
import ( | ||
"fmt" | ||
|
||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/client-go/tools/cache" | ||
) | ||
|
||
var _ cache.TransformFunc = PartialMetadataRemoveTransform | ||
|
||
// partialMetadataRemoveAll implements a cache.TransformFunc that removes managed | ||
// fields from PartialObjectMetadata. | ||
func PartialMetadataRemoveTransform(obj interface{}) (interface{}, error) { | ||
partialMeta, ok := obj.(*metav1.PartialObjectMetadata) | ||
if !ok { | ||
return nil, fmt.Errorf("internal error: cannot cast object %#+v to PartialObjectMetadata", obj) | ||
} | ||
partialMeta.ManagedFields = nil | ||
return partialMeta, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
Copyright 2022 The Koordinator Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package transformer | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
) | ||
|
||
func TestTransformMetadata(t *testing.T) { | ||
tests := []struct { | ||
name string | ||
pod *metav1.PartialObjectMetadata | ||
wantPod *metav1.PartialObjectMetadata | ||
}{ | ||
{ | ||
name: "normal pod metadata transform", | ||
pod: &metav1.PartialObjectMetadata{ | ||
TypeMeta: metav1.TypeMeta{ | ||
Kind: "Pod", | ||
APIVersion: "v1", | ||
}, | ||
ObjectMeta: metav1.ObjectMeta{ | ||
Name: "name", | ||
Namespace: "ns", | ||
ManagedFields: []metav1.ManagedFieldsEntry{}, | ||
}, | ||
}, | ||
|
||
wantPod: &metav1.PartialObjectMetadata{ | ||
TypeMeta: metav1.TypeMeta{ | ||
Kind: "Pod", | ||
APIVersion: "v1", | ||
}, | ||
ObjectMeta: metav1.ObjectMeta{ | ||
Name: "name", | ||
Namespace: "ns", | ||
ManagedFields: nil, | ||
}, | ||
}, | ||
}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
obj, err := PartialMetadataRemoveTransform(tt.pod) | ||
assert.NoError(t, err) | ||
assert.Equal(t, tt.wantPod, obj) | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If set PartialMetadataRemoveTransform as transformer here, it will replace the exist transformer. It's not the expected.
If you want to do this, you should wrap the transformFn with PartialMetadataRemoveTransform.