Skip to content

Commit

Permalink
xtask: Remove overeager skipping web build.
Browse files Browse the repository at this point in the history
This is now apparently causing a CI failure; I think because I moved
the output into `target/` and the cache action is leaving empty
directories present.
  • Loading branch information
kpreid committed Nov 8, 2024
1 parent 573b08a commit dd6665a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions tools/xtask/src/xtask.rs
Original file line number Diff line number Diff line change
Expand Up @@ -688,13 +688,8 @@ fn do_for_all_packages(
ensure_wasm_tools_installed(config, time_log)?;
}

// Ensure all-is-cubes-server build that might be looking for the files will succeed.
// Note that this is only an “exists” check not a “up-to-date” check, on the assumption
// that running server tests will not depend on the specific file contents.
// TODO: That's a fragile assumption.
if config.scope.includes_main_workspace() && !static_web_app_out_dir(Profile::Dev).exists() {
build_web(config, time_log, Profile::Dev)?;
}
// Ensure all-is-cubes-server build that might be looking for the web client files will succeed.
build_web(config, time_log, Profile::Dev)?;

// Test everything we can with default features and target.
// But if we're linting, then the below --all-targets run will handle that.
Expand Down

0 comments on commit dd6665a

Please sign in to comment.