Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation steps to embedders #332

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add validation steps to embedders #332

wants to merge 5 commits into from

Conversation

simonusher
Copy link
Collaborator

closes #277

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #332 (ed9790c) into main (6f86d36) will decrease coverage by 0.72%.
The diff coverage is 64.00%.

❗ Current head ed9790c differs from pull request most recent head 7e0cc63. Consider uploading reports for the commit 7e0cc63 to get more accurate results

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   91.71%   91.00%   -0.72%     
==========================================
  Files          60       60              
  Lines        2112     2145      +33     
==========================================
+ Hits         1937     1952      +15     
- Misses        175      193      +18     
Flag Coverage Δ
macos-latest-python3.11 90.48% <64.00%> (-0.71%) ⬇️
ubuntu-latest-python3.10 89.79% <64.00%> (-0.70%) ⬇️
ubuntu-latest-python3.11 89.79% <64.00%> (-0.70%) ⬇️
ubuntu-latest-python3.8 89.77% <64.00%> (-0.70%) ⬇️
ubuntu-latest-python3.9 89.77% <64.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
srai/embedders/gtfs2vec/model.py 80.55% <12.50%> (-19.45%) ⬇️
srai/embedders/highway2vec/model.py 97.05% <50.00%> (-2.95%) ⬇️
srai/embedders/hex2vec/embedder.py 72.91% <62.50%> (-1.81%) ⬇️
srai/embedders/highway2vec/embedder.py 66.66% <72.72%> (-2.00%) ⬇️
srai/embedders/gtfs2vec/embedder.py 78.99% <80.95%> (-1.75%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@piotrgramacki piotrgramacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to pass validation dataset to model fitting
4 participants