fix: inject version for path dependencies in workspace virtual manifests #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unhandled case in version injection task.
For a project with virtual manifest like this:
Kraken would not inject
version
andregistry
attributes.This MR fixes it, by correctly injecting versions for dependencies declared in workspaces with virtual manifest.
Decisions:
_raw
attribute to most manifest related classes, store raw JSON data there (without removing the handled fields)_raw
and use a getter with deprecation warning for backward compatibilityto_json
methods could be simplified, as they can simply returnself._raw