Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kanel-kysely: Differentiate null and undefined for insert types #488

Merged
merged 1 commit into from
Nov 16, 2023
Merged

kanel-kysely: Differentiate null and undefined for insert types #488

merged 1 commit into from
Nov 16, 2023

Conversation

m12y
Copy link
Contributor

@m12y m12y commented Nov 15, 2023

If a column is not nullable, we should not allow null in the insert (results in database error). However we may still allow undefined in the insert for generated columns and columns with default value.

@kristiandupont kristiandupont merged commit 9f70682 into kristiandupont:main Nov 16, 2023
1 check passed
@kristiandupont
Copy link
Owner

This one is published as well. Thank you again for contributing! :-)

@m12y m12y deleted the insert-undefined branch November 16, 2023 08:45
@m12y
Copy link
Contributor Author

m12y commented Nov 16, 2023

@kristiandupont Thanks for the quick publishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants