Fix escaping table names and fields #506
Conversation
|
I think this is all working in |
|
I think that should do it. I've tested with the horrific example in #505 and it passes perfectly with both |
|
Requesting review from @kristiandupont |
| typeDefinition: string[]; | ||
| exportAs: "named" | "default"; | ||
| }; | ||
|
|
||
| export type InterfacePropertyDeclaration = { | ||
| export type InterfacePropertyDeclaration = DeclarationBase & { |
There was a problem hiding this comment.
The reason I didn't do this is that you can't add a prop declaration directly to a file. But it's a semantic difference, this is fine.
| @@ -0,0 +1,5 @@ | |||
| /** Used for comment text. */ | |||
| const escapeComment = (name: string): string => | |||
There was a problem hiding this comment.
Nice! I had thought of this but not needed it thus far :-)
|
Wow, you put a lot of work into this and managed to stay true to my weird conventions and patterns, that's impressive! Thank you! |
|
Both packages are published |
|
Thank you for reviewing, approving, merging and releasing so fast! This is a huge help :) Have a brilliant weekend. |
Fixes #505