Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-special-symbols #222

Closed
wants to merge 2 commits into from
Closed

fix-special-symbols #222

wants to merge 2 commits into from

Conversation

jorgefandinno
Copy link
Contributor

@jorgefandinno jorgefandinno commented Dec 27, 2024

Added automatic format of special characters in names to the format-names command according to the README.

Use LaTeX commands for special characters in all fields avoiding unnecessary braces but putting them around the command.

example: J. P{\"a}tynen but neither J. Pätynen, J. P\"atynen, J. P\"{a}tynen, nor J. P{\"{a}}tynen.

This was applied to the current entries, where several inconsistencies were found. Please, check that this is the desired format. Specifically, is Gon{\c c}alves prefered to Gon{\c{c}}alves?

@jorgefandinno jorgefandinno marked this pull request as draft December 27, 2024 17:10
@jorgefandinno jorgefandinno reopened this Dec 27, 2024
@jorgefandinno jorgefandinno marked this pull request as ready for review December 27, 2024 17:31
@tortinator
Copy link
Contributor

Muchas gracias y feliz navidad, @jorgefandinno, I let @rkaminsk review - my python is a bit rusty 😇

@rkaminsk
Copy link
Contributor

Do we really want to touch the script here? We could also just leave the script as is and remove this part of the readme as latex special characters are formatted in a consistent way.

@jorgefandinno
Copy link
Contributor Author

jorgefandinno commented Dec 28, 2024

Do we really want to touch the script here? We could also just leave the script as is and remove this part of the readme as latex special characters are formatted in a consistent way.

Fine with me. Dblp uses the format {\’{a}}. Rather than removing it, I will modify it as:

example: J. P{\"a}tynen or J. P{\"{a}}tynen but neither J. Pätynen, J. P\"atynen, J. P\"{a}tynen

These two versions produce the same result, but the other versions are incorrect.

@rkaminsk
Copy link
Contributor

@jorgefandinno, would you care to update the README, please. I did not investigate the details and it would be hard for me to come up to speed. Closing this branch.

@rkaminsk rkaminsk closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants