Adds constants for each api version in kruize, and changes the list r…

…ecommendation SO to have specific version of API rather than having the kruize object version Signed-off-by: bharathappali <[email protected]>
kruize · Nov 3, 2023 · 3866b67 · 3866b67
1 parent b929706
commit 3866b67
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/main/java/com/autotune/analyzer/kruizeObject/KruizeObject.java b/src/main/java/com/autotune/analyzer/kruizeObject/KruizeObject.java
@@ -82,6 +82,7 @@ public KruizeObject(String experimentName,
 
         StringBuilder error = ValidateKruizeObject.validate(map);
         if (error.toString().isEmpty()) {
+            this.apiVersion = AnalyzerConstants.VersionConstants.CURRENT_KRUIZE_OBJECT_VERSION;
             this.experimentName = experimentName;
             this.mode = mode;
             this.targetCluster = targetCluster;

diff --git a/src/main/java/com/autotune/analyzer/serviceObjects/Converters.java b/src/main/java/com/autotune/analyzer/serviceObjects/Converters.java
@@ -98,7 +98,7 @@ public static ListRecommendationsAPIObject convertKruizeObjectToListRecommendati
                 Timestamp monitoringEndTime) {
             ListRecommendationsAPIObject listRecommendationsAPIObject = new ListRecommendationsAPIObject();
             try {
-                listRecommendationsAPIObject.setApiVersion(kruizeObject.getApiVersion());
+                listRecommendationsAPIObject.setApiVersion(AnalyzerConstants.VersionConstants.APIVersionConstants.CURRENT_LIST_RECOMMENDATIONS_VERSION);
                 listRecommendationsAPIObject.setExperimentName(kruizeObject.getExperimentName());
                 listRecommendationsAPIObject.setClusterName(kruizeObject.getClusterName());
                 List<KubernetesAPIObject> kubernetesAPIObjects = new ArrayList<>();
@@ -190,7 +190,7 @@ public static ListRecommendationsAPIObject convertKruizeObjectToListRecommendati
                 String monitoringEndTimestamp) {
             ListRecommendationsAPIObject listRecommendationsAPIObject = new ListRecommendationsAPIObject();
             try {
-                listRecommendationsAPIObject.setApiVersion(kruizeObject.getApiVersion());
+                listRecommendationsAPIObject.setApiVersion(AnalyzerConstants.VersionConstants.APIVersionConstants.CURRENT_LIST_RECOMMENDATIONS_VERSION);
                 listRecommendationsAPIObject.setExperimentName(kruizeObject.getExperimentName());
                 listRecommendationsAPIObject.setClusterName(kruizeObject.getClusterName());
                 List<KubernetesAPIObject> kubernetesAPIObjects = new ArrayList<>();

diff --git a/src/main/java/com/autotune/analyzer/utils/AnalyzerConstants.java b/src/main/java/com/autotune/analyzer/utils/AnalyzerConstants.java
@@ -531,4 +531,20 @@ private BooleanString() {
 
         }
     }
+
+    public static final class VersionConstants {
+        public static final class APIVersionConstants {
+            public static final String CURRENT_CREATE_EXPERIMENT_VERSION = "v1.0";
+            public static final String CURRENT_UPDATE_RESULTS_VERSION = "v1.0";
+            public static final String CURRENT_LIST_RECOMMENDATIONS_VERSION = "v2.0";
+            public static final String CURRENT_UPDATE_RECOMMENDATIONS_VERSION = "v2.0";
+            private APIVersionConstants() {
+
+            }
+        }
+        public static final String CURRENT_KRUIZE_OBJECT_VERSION = "v1.0";
+        private VersionConstants() {
+
+        }
+    }
 }