minor change to fix response in case of createExp

Signed-off-by: Saad Khan <[email protected]>
kruize · Dec 4, 2023 · 753fb05 · 753fb05
1 parent 6a5d4c4
commit 753fb05
Showing 1 changed file with 19 additions and 11 deletions.
diff --git a/src/main/java/com/autotune/analyzer/exceptions/KruizeErrorHandler.java b/src/main/java/com/autotune/analyzer/exceptions/KruizeErrorHandler.java
@@ -59,17 +59,25 @@ public void handle(String target, Request baseRequest, HttpServletRequest reques
                 .create();
         String gsonStr = gsonObj.toJson(new KruizeResponse(origMessage, errorCode, "", "ERROR", myList));
 
-        // Log messages based on httpcode
-        myList.forEach(updateResult ->
-                updateResult.getErrors().forEach(error -> {
-                    if (error.getHttpcode() == 409) {
-                        LOGGER.debug(gsonObj.toJson(error));
-                    } else {
-                        LOGGER.error(gsonObj.toJson(error));
-                    }
-                })
-        );
-
+            // suppress error in case of duplicate records entry and show errors for all other failed cases.
+            // in case of createExp API, data object will be empty so 'myList' will be null
+            if (myList == null) {
+                if (errorCode == HttpServletResponse.SC_CONFLICT) {
+                    LOGGER.debug(gsonStr);
+                } else {
+                    LOGGER.error(gsonStr);
+                }
+            } else {
+                myList.forEach(failedResult ->
+                        failedResult.getErrors().forEach(error -> {
+                            if (error.getHttpcode() == 409) {
+                                LOGGER.debug(gsonObj.toJson(error));
+                            } else {
+                                LOGGER.error(gsonObj.toJson(error));
+                            }
+                        })
+                );
+            }
         out.append(gsonStr);
         out.flush();
     }