Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update tests for the listRecommendations and UpdateRecommendations APIs #981

Merged
merged 12 commits into from
Nov 7, 2023
Merged

Add and update tests for the listRecommendations and UpdateRecommendations APIs #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
76683c8
basic changes for fixing the sanity failures
khansaad Oct 12, 2023
620dfa1
test updates
khansaad Oct 12, 2023
bffcbc3
add schema, update docs and other notifications test changes
khansaad Oct 26, 2023
f4d54f1
updates wrt the review
khansaad Oct 31, 2023
f283324
update tests for list recommendations, add schema for medium and long…
khansaad Nov 3, 2023
4eb2e15
optimize term recommendations test functions, fix e2e tests
khansaad Nov 3, 2023
032dce5
Merge pull request #1021 from kruize/mvp_demo
dinogun Nov 3, 2023
fd75ef1
minor changes to include variation values check, cosmetic changes as …
khansaad Nov 3, 2023
77a2167
Merge remote-tracking branch 'upstream/master' into perf-profile-tests
khansaad Nov 6, 2023
194a562
Merge remote-tracking branch 'upstream/mvp_demo' into perf-profile-tests
khansaad Nov 6, 2023
056a8c9
update notifications codes test, add new test function for negative c…
khansaad Nov 6, 2023
820bc90
minor update to change the function parameter name
khansaad Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
210 changes: 159 additions & 51 deletions design/MonitoringModeAPI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3003,71 +3003,165 @@ The response will contain a array of JSON object with the updated recommendation
"container_image_name": "kruize/tfb-qrh:1.13.2.F_et17",
"container_name": "tfb-server-1",
"recommendations": {
"version": "1.0",
"notifications": {
"112101": {
"111000": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see notification codes doc with this code and a few other codes are missing, can you please check and update the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc in mvp_demo is updated, we will need to update the doc in the remote_monitoring branch

"type": "info",
"message": "Duration Based Recommendations Available",
"code": 112101
"message": "Recommendations Are Available",
"code": 111000
}
},
"data": {
"2023-01-02T00:15:00.000Z": {
"duration_based": {
"2023-04-02T13:30:00.680Z": {
"notifications": {
"111101": {
"type": "info",
"message": "Short Term Recommendations Available",
"code": 111101
}
},
"monitoring_end_time": "2023-04-02T13:30:00.680Z",
"current": {
"limits": {
"memory": {
"amount": 100.0,
"format": "MiB"
},
"cpu": {
"amount": 0.5,
"format": "cores"
}
},
"requests": {
"memory": {
"amount": 50.21,
"format": "MiB"
},
"cpu": {
"amount": 5.37,
"format": "cores"
}
}
},
"recommendation_terms": {
"short_term": {
"monitoring_start_time": "2023-01-01T00:15:00.000Z",
"monitoring_end_time": "2023-01-02T00:15:00.000Z",
"duration_in_hours": 24.0,
"pods_count": 7,
"confidence_level": 0.0,
"config": {
"limits": {
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
},
"memory": {
"amount": 238.2,
"format": "MiB"
}
"notifications": {
"112101": {
"type": "info",
"message": "Cost Recommendations Available",
"code": 112101
},
"requests": {
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
},
"memory": {
"amount": 238.2,
"format": "MiB"
}
"112102": {
"type": "info",
"message": "Performance Recommendations Available",
"code": 112102
}
},
"variation": {
"limits": {
"cpu": {
"amount": 0.42999999999999994,
"format": "cores"
"monitoring_start_time": "2023-04-01T12:00:00.000Z",
"recommendation_engines": {
"cost": {
"pods_count": 7,
"confidence_level": 0.0,
"config": {
"limits": {
"memory": {
"amount": 238.2,
"format": "MiB"
},
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
}
},
"requests": {
"memory": {
"amount": 238.2,
"format": "MiB"
},
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
}
}
},
"memory": {
"amount": 138.2,
"format": "MiB"
}
"variation": {
"limits": {
"memory": {
"amount": 138.2,
"format": "MiB"
},
"cpu": {
"amount": -4.44,
"format": "cores"
}
},
"requests": {
"memory": {
"amount": 187.98999999999998,
"format": "MiB"
},
"cpu": {
"amount": -4.44,
"format": "cores"
}
}
},
"notifications": {}
},
"requests": {
"cpu": {
"amount": -0.17000000000000015,
"format": "cores"
"performance": {
"pods_count": 27,
"confidence_level": 0.0,
"config": {
"limits": {
"memory": {
"amount": 238.2,
"format": "MiB"
},
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
}
},
"requests": {
"memory": {
"amount": 238.2,
"format": "MiB"
},
"cpu": {
"amount": 0.9299999999999999,
"format": "cores"
}
}
},
"memory": {
"amount": 187.98999999999998,
"format": "MiB"
}
"variation": {
"limits": {
"memory": {
"amount": 138.2,
"format": "MiB"
},
"cpu": {
"amount": -4.44,
"format": "cores"
}
},
"requests": {
"memory": {
"amount": 187.98999999999998,
"format": "MiB"
},
"cpu": {
"amount": -4.44,
"format": "cores"
}
}
},
"notifications": {}
}
},
"notifications": []
}
},
"medium_term": {
"pods_count": 0,
"confidence_level": 0.0,
"duration_in_hours": 33.8,
"notifications": {
"120001": {
"type": "info",
Expand All @@ -3077,8 +3171,7 @@ The response will contain a array of JSON object with the updated recommendation
}
},
"long_term": {
"pods_count": 0,
"confidence_level": 0.0,
"duration_in_hours": 33.8,
"notifications": {
"120001": {
"type": "info",
Expand All @@ -3091,6 +3184,21 @@ The response will contain a array of JSON object with the updated recommendation
}
}
}
},
{
"container_image_name": "kruize/tfb-db:1.15",
"container_name": "tfb-server-0",
"recommendations": {
"version": "1.0",
"notifications": {
"120001": {
"type": "info",
"message": "There is not enough data available to generate a recommendation.",
"code": 120001
}
},
"data": {}
}
}
]
}
Expand Down
Loading
Loading