Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set particular locales for application (#135) #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seniorihor
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 99.76% when pulling e915793 on defself:master into c24a2ed on kslazarev:master.

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage decreased (-0.1%) to 99.403% when pulling e915793 on defself:master into c24a2ed on kslazarev:master.

@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 99.403% when pulling d5146ac on defself:master into c24a2ed on kslazarev:master.

@coveralls
Copy link

coveralls commented Dec 16, 2016

Coverage Status

Coverage decreased (-0.1%) to 99.403% when pulling 2bfec0d on defself:master into c24a2ed on kslazarev:master.

@dblock
Copy link
Collaborator

dblock commented Dec 16, 2016

This works but I don't love it as it sets a global constant for configuration. There be dragons. At the very least it feels like it requires complicated gymnastics like require: false and manual loading. There's probably a simpler solution to delay setting I18n.locale_file setting and/or to unload whatever is there when the locales are assigned and replace with new values.

I think as a developer I'd want to do this, which is similar to other gems:

NumbersAndWords.configure do |config|
   config.locales = [:en, :ru]
end

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage decreased (-32.9%) to 66.624% when pulling 399d9cf on defself:master into c24a2ed on kslazarev:master.

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage decreased (-0.1%) to 99.403% when pulling 4168153 on defself:master into c24a2ed on kslazarev:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants