Skip to content

Commit

Permalink
Fix even more lint issues
Browse files Browse the repository at this point in the history
Signed-off-by: Tom Zaspel <[email protected]>
  • Loading branch information
tzabbi committed Jul 31, 2024
1 parent 0f74042 commit 5784fca
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/dex_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ jobs:
- name: test dex login
run: |
pip3 install requests
./tests/gh-actions/test_dex_login.py
pip3 install requests
./tests/gh-actions/test_dex_login.py
1 change: 0 additions & 1 deletion .github/workflows/manifests_example_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,3 @@ jobs:
- name: Unit Test
run: |
kustomize build example
4 changes: 2 additions & 2 deletions .github/workflows/model_registry_test.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# If anyone changes or improve the following tests for Model Registry, please
# If anyone changes or improve the following tests for Model Registry, please
# consider reflecting the same changes on https://github.com/kubeflow/model-registry
name: Deploy and test Kubeflow Model Registry
on:
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
'http://localhost:8081/api/model_registry/v1alpha3/registered_models?pageSize=100&orderBy=ID&sortOrder=DESC' \
-H 'accept: application/json'
# for these steps below ensure same steps as kserve (ie: Istio with external authentication, cert-manager, knative) so to achieve same setup
# for these steps below ensure same steps as kserve (ie: Istio with external authentication, cert-manager, knative) so to achieve same setup
- name: Port forward Istio gateway
run: |
INGRESS_GATEWAY_SERVICE=$(kubectl get svc --namespace istio-system --selector="app=istio-ingressgateway" --output jsonpath='{.items[0].metadata.name}')
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/stale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,21 +22,21 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: 60
days-before-close: 21
# The message that will be added as a comment to the issues
# The message that will be added as a comment to the issues
# when the stale workflow marks it automatically as stale with a label.
stale-issue-message: >
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
# The message that will be added as a comment to the issues
# The message that will be added as a comment to the issues
# when the stale workflow closes it automatically after being stale for too long.
close-issue-message: >
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.
stale-issue-label: lifecycle/stale
# Exclude them from being marked as stale
exempt-issue-labels: lifecycle/frozen,enhancement,good first issue
# The message that will be added as a comment to the pull requests
# The message that will be added as a comment to the pull requests
# when the stale workflow marks it automatically as stale with a label.
stale-pr-message: "This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. \n"
# The message that will be added as a comment to the pull requests
# The message that will be added as a comment to the pull requests
# when the stale workflow closes it automatically after being stale for too long.
close-pr-message: "This pull request has been automatically closed because it has not had recent activity.You can reopen the PR if you want. \n"
stale-pr-label: lifecycle/stale
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/triage_issues.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Define a GitHub action workflow to determine whether issues
# Define a GitHub action workflow to determine whether issues
# should be added or removed from the Needs Triage Kanban board.
name: Check Triage Status of Issue
on:
Expand All @@ -16,4 +16,3 @@ jobs:
# Letting input NEEDS_TRIAGE_PROJECT_CARD_ID use the default value
ISSUE_NUMBER: ${{ github.event.issue.number }}
GITHUB_PERSONAL_ACCESS_TOKEN: ${{ secrets.triage_projects_github_token }}

2 changes: 0 additions & 2 deletions .github/workflows/trivy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,3 @@ jobs:
# with:
# name: trivy_scanned_results
# path: image_lists/


0 comments on commit 5784fca

Please sign in to comment.