Upgrade Istio to v1.24.2

[biswajit-9776]

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I upgraded Istio from version 1.23.2 to 1.24.2

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist

• Make sure you have tested with kustomize. See Installation Prerequisites
• All the commits have been signed-off (To pass the DCO check)

---

You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

[biswajit-9776]

Hello @juliusvonkohout, I used the same profile.yaml to install istio-1.24.2 and manually changed spec.tag: 1.24.2 as they have removed the istioctl profile command in their 1.24.x release.

However, inspecting the manifest it generates, seems they have removed the ingressgateway service. Could you confirm if this is true as I'm unable to check it in their release docs.

[juliusvonkohout]

Hello @juliusvonkohout, I used the same profile.yaml to install istio-1.24.2 and manually changed spec.tag: 1.24.2 as they have removed the istioctl profile command in their 1.24.x release.

However, inspecting the manifest it generates, seems they have removed the ingressgateway service. Could you confirm if this is true as I'm unable to check it in their release docs.

That is interesting are you sure that profiles are gone? Can you check the git diff ?

[biswajit-9776]

The profiles are there which you could see in 1.24 release, they however removed the istioctl profile command which we were able to use before.
We could still use our existing profile.yaml for that manually.
What do you think about the ingress gateway service? Should we add it as a patch in the 1.24 upgrade?

[juliusvonkohout]

The profiles are there which you could see in 1.24 release, they however removed the istioctl profile command which we were able to use before. We could still use our existing profile.yaml for that manually. What do you think about the ingress gateway service? Should we add it as a patch in the 1.24 upgrade?

Could it be that it has been replaced by https://gateway-api.sigs.k8s.io/ ? But yes we definitely need some kind of gateway, either the old style or the new API and a service that exposes it within Kubernetes.

[biswajit-9776]

Well we did plan to adopt the gateway API as per issue.
Do correct me if I am wrong, we could either first switch to Gateway API and then upgrade to Istio 1.24.x or include the service patches like the old style in this PR and later migrate to Gateway API.

[juliusvonkohout]

Well we did plan to adopt the gateway API as per issue. Do correct me if I am wrong, we could either first switch to Gateway API and then upgrade to Istio 1.24.x or include the service patches like the old style in this PR and later migrate to Gateway API.

Lets keep the changes per PR small for easier reviews, so try to replicate the status quo first and continue in follow-up PRs.

[juliusvonkohout]

What a PR. Took me an hour to review :-D

@biswajit-9776 can you create the follow up PR to switch to the gateway API ?

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[biswajit-9776]

Hope the changes didn't bother you much :)
I will see if Gateway API works locally and replaces the work done by files I added to this PR.