Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Disable GKE Metadata as default Fixes: #11247, fixes #11260 #11403

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dvcanton
Copy link
Contributor

Description of your changes:

Fixes: #11247 & #11260

Duplicated from #11321 to include tests.

Checklist:

Copy link

Hi @dvcanton. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

@dvcanton can you take a look at the failing tests?

@dvcanton dvcanton force-pushed the disable-gke-metadata branch from 2c494c6 to 9efbcec Compare November 26, 2024 19:42
@dvcanton dvcanton force-pushed the disable-gke-metadata branch from 9efbcec to e94d260 Compare November 26, 2024 20:04
@dvcanton
Copy link
Contributor Author

Hi @hbelmiro, thanks for the heads up. I have looked into the frontend server tests. They all pass locally now.

Test Suites: 10 passed, 10 total
Tests:       128 passed, 128 total
Snapshots:   12 passed, 12 total
Time:        8.185s, estimated 9s
Ran all test suites.

@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 27, 2024
@HumairAK
Copy link
Collaborator

@dvcanton thank you!

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 23f718d into kubeflow:master Nov 27, 2024
14 checks passed
@HumairAK HumairAK added this to the KFP 2.4.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm needs-ok-to-test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ml-pipeline-ui failing on metadata api
3 participants