-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): Resolves issue when using task dependent on ParallelFor completion #11476
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @farridav. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Approvals successfully granted for pending runs. |
@farridav Before sending the PR, it would be good ensure that your contribution relies on the KFP code style. You can take a look at https://github.com/kubeflow/pipelines/blob/master/sdk/CONTRIBUTING.md#code-style for more reference. In the failed test, you need to run this command to understand what you need to change:
|
/ok-to-test |
Approvals successfully granted for pending runs. |
…line parameters, are wrongly expected to have task attributes Signed-off-by: David Farrington <[email protected]>
/ok-to-test |
Approvals successfully granted for pending runs. |
Fix issue where tasks preceeding parallel for loops that recieve pipeline parameters, are wrongly expected to have task attributes
Description of your changes:
Im checking to see if the channel input actually has a task before trying to get its name, avoiding an
AttributeError
that i get otherwiseChecklist: