Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fixes SDK tests #11488

Merged
merged 1 commit into from
Dec 29, 2024
Merged

test: fixes SDK tests #11488

merged 1 commit into from
Dec 29, 2024

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Dec 26, 2024 •
edited
Loading

SDK Tests have been broken since December 18th.

https://github.com/kubeflow/pipelines/actions/runs/12399881929/job/34615777065

This PR fixes that.

Checklist:

@google-oss-prow Google OSS Prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow google-oss-prow bot added size/XS and removed size/L labels Dec 26, 2024
@hbelmiro hbelmiro marked this pull request as ready for review December 26, 2024 15:12
@google-oss-prow google-oss-prow bot requested a review from jlyaoyuli December 26, 2024 15:13
@hbelmiro hbelmiro changed the title Fix sdk tests chore(tests): fix SDK tests Dec 26, 2024
@hbelmiro hbelmiro changed the title chore(tests): fix SDK tests chore(tests): fixes SDK tests Dec 26, 2024
@hbelmiro
chore(tests): fix SDK tests
d4147a9 
Signed-off-by: Helber Belmiro <[email protected]>
@hbelmiro
Copy link
Contributor Author

@DharmitD @HumairAK can one of you guys PTAL?

@hbelmiro hbelmiro changed the title chore(tests): fixes SDK tests test: fixes SDK tests Dec 26, 2024
DharmitD
DharmitD approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @hbelmiro !

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 29, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DharmitD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 9c6ec0f into kubeflow:master Dec 29, 2024
28 checks passed
@hbelmiro hbelmiro deleted the fix-sdk-tests branch December 30, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DharmitD DharmitD DharmitD approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@rimolive rimolive Awaiting requested review from rimolive

@jlyaoyuli jlyaoyuli Awaiting requested review from jlyaoyuli

Assignees

@DharmitD DharmitD

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbelmiro @DharmitD