Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add integration test github action #68

Merged
merged 1 commit into from
Jan 9, 2025
Merged

add integration test github action #68

merged 1 commit into from
Jan 9, 2025

Conversation

Rakshith-R
Copy link
Contributor

@Rakshith-R Rakshith-R commented Nov 14, 2024 •
edited
Loading

What type of PR is this?

This commits add basic github action
for intergration test.
This action

  • starts minikube
  • builds latest csi-snapshot-metadata image
  • deploy snapshot-controller
  • deploy csi-hostpath-driver
  • deploy backup client app
  • creates pvc, writes data, takes snapshots
  • executes tests with single snapshot and two snapshots
    to test both RPCs
  • on failure
    • logs necessary information
    • setups up tmate session to debug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Updates: #67

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Rakshith-R. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 14, 2024
@Rakshith-R
Copy link
Contributor Author

example run:
https://github.com/Rakshith-R/external-snapshot-metadata/actions/runs/11837879569/job/32985788280?pr=5

/cc @carlbraganza @PrasadG193

@Rakshith-R Rakshith-R force-pushed the integration-test-gh-action branch from d5718ca to 7da7ac6 Compare November 29, 2024 10:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2024
@Rakshith-R Rakshith-R force-pushed the integration-test-gh-action branch from 7da7ac6 to e1a6429 Compare November 29, 2024 15:19
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2024
@Rakshith-R Rakshith-R force-pushed the integration-test-gh-action branch from e1a6429 to c77d9df Compare December 2, 2024 12:42
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@Rakshith-R Rakshith-R force-pushed the integration-test-gh-action branch 11 times, most recently from bc58d71 to 005a573 Compare December 4, 2024 16:02
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@hairyhum
Copy link
Contributor

hairyhum commented Dec 6, 2024

/lgtm

It would also be nice to have those scripts runnable from a shell file and/or make target in order to run locally or in prow (doesn't have to be a part of this PR)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2024
@Rakshith-R
add intergration test github action
3f65960 
This commits add basic github action
for intergration test.
This action
- starts minikube
- builds latest csi-snapshot-metadata image
- deploy snapshot-controller
- deploy csi-hostpath-driver
- deploy backup client app
- creates pvc, writes data, takes snapshots
- executes tests with single snapshot and two snapshots
  to test both RPCs
- on failure
  - logs necessary information
  - setups up tmate session to debug

Signed-off-by: Rakshith R <[email protected]>
@Rakshith-R Rakshith-R force-pushed the integration-test-gh-action branch from 005a573 to 3f65960 Compare January 9, 2025 13:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 9, 2025
Rakshith-R
Rakshith-R commented Jan 9, 2025
View reviewed changes
.github/workflows/integration-test.yaml
run: |
kubectl apply -f ./client/config/crd/cbt.storage.k8s.io_snapshotmetadataservices.yaml

git clone https://github.com/rakshith-r/csi-driver-host-path.git ~/csi-driver-host-path
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll switch this with official repo once https://github.com/kubernetes-csi/csi-driver-host-path/pull/575/files goes in.

@Rakshith-R
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2025
@hairyhum
Copy link
Contributor

hairyhum commented Jan 9, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7299d64 into kubernetes-csi:main Jan 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

@hairyhum hairyhum Awaiting requested review from hairyhum

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193

Assignees

@hairyhum hairyhum

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rakshith-R @k8s-ci-robot @hairyhum