Client error propagation #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
carlbraganza
force-pushed
the
client-error-to-driver
branch
from
0f12ac8 to
d24c9fc
Compare
|
/assign @PrasadG193 |
carlbraganza
force-pushed
the
client-error-to-driver
branch
2 times, most recently
from
1954211 to
fa2884c
Compare
carlbraganza
commented
Dec 13, 2024
carlbraganza
force-pushed
the
client-error-to-driver
branch
4 times, most recently
from
1d0baba to
b605c85
Compare
k8s-ci-robot
added
size/XL
carlbraganza
force-pushed
the
client-error-to-driver
branch
4 times, most recently
from
051fe84 to
4e99c01
Compare
Rakshith-R
reviewed
Dec 17, 2024
PrasadG193
reviewed
Dec 18, 2024
| // Create a timeout context so that failure in either sending to the client or | ||
| // receiving from the CSI driver will ultimately abort the handler session. | ||
| // The context could also get canceled by the client. | ||
| ctx, cancelFn := context.WithTimeout(s.getMetadataAllocatedContextWithLogger(req, stream), s.config.MaxStreamDur) |
There was a problem hiding this comment.
just to confirm, this timeout will be applicable for take taken for complete data transfer not just a page (maxResults), right?
There was a problem hiding this comment.
Yes, that is correct - it will span multiple pages.
carlbraganza
force-pushed
the
client-error-to-driver
branch
from
4e99c01 to
b28723c
Compare
carlbraganza
force-pushed
the
client-error-to-driver
branch
from
b28723c to
29b0c54
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlbraganza, PrasadG193 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that client errors (context cancellation or failure to read responses) will result in the CSI driver stream being canceled.
What type of PR is this?
What this PR does / why we need it:
This ensures that when a client aborts its receive stream, or stops reading responses, or the network connection between the client and the sidecar fails, the CSI driver stream will get canceled.
Which issue(s) this PR fixes:
Fixes #66
Special notes for your reviewer:
Does this PR introduce a user-facing change?: