Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix golang version getter bash script in Makefile #342

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Jan 14, 2025

What this PR does / why we need it:
This is fix for bug introduced in #340. CI job post-cluster-api-addon-provider-helm-push-images is utilizing BusyBox v1.35.0 (2022-08-01 15:14:44 UTC) multi-call binary set, which has number of limitations for grep, awk, etc. utilities.
This fix should work for regular OS as well for CI busybox.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmvolod
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @dmvolod. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@Jont828
Copy link
Contributor

Jont828 commented Jan 14, 2025

/ok-to-test

LGTM as well pending tests passing. Have you verified this works with busybox? I don't think our CI uses it so it won't test that it solves your use case.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2025
@dmvolod
Copy link
Contributor Author

dmvolod commented Jan 15, 2025

LGTM as well pending tests passing. Have you verified this works with busybox? I don't think our CI uses it so it won't test that it solves your use case.

It happens in Kubernetes CI job (prow.k8s.io) and seems to gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20221007-ad65926f6b image contains only BusyBox multi-call binary set for optimizing size. We are not using busybox in our CI.

Please have a look at this log
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/post-cluster-api-addon-provider-helm-push-images/1878889396527173632

In this case, we need to validate that all utility (sed, grep, awk, etc.) options utilizing inside the Makefile or any shell scrips which are running in CI (not only locally) are busybox compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants