Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for adding/removing FD in KCP #11602

Open
fabriziopandini opened this issue Dec 20, 2024 · 3 comments
Open

Add test coverage for adding/removing FD in KCP #11602

fabriziopandini opened this issue Dec 20, 2024 · 3 comments
Assignees
@arshadd-b
Labels
area/provider/control-plane-kubeadm Issues or PRs related to KCP area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Dec 20, 2024 •
edited
Loading

While implementing #11598 I noticed that test coverage for failure domain management in KCP is minimal or not existent.

The PR partially addressed the tech debt by implementing test coverage for the failuredomains package (which was modified by the PR), but the upper layer of the call stack (scale.go, control_plane.go) still lack of test coverage, mostly with regards of scenarios where we are adding or removing failure domains.

/kind cleanup
/area provider/control-plane-kubeadm
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 20, 2024
@fabriziopandini fabriziopandini added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/provider/control-plane-kubeadm Issues or PRs related to KCP and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 20, 2024
@fabriziopandini fabriziopandini mentioned this issue Dec 20, 2024
Merged
@sbueringer sbueringer added the area/testing Issues or PRs related to testing label Dec 27, 2024
@arshadd-b
Copy link

/assign

@arshadd-b
Copy link

I am interested, will work on this

@arshadd-b arshadd-b mentioned this issue Jan 15, 2025
Open
@chrischdi
Copy link
Member

/assign @arshadd-b

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels Jan 22, 2025
@chrischdi chrischdi added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arshadd-b arshadd-b

Labels
area/provider/control-plane-kubeadm Issues or PRs related to KCP area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chrischdi @sbueringer @fabriziopandini @k8s-ci-robot @arshadd-b