🌱 Add UTs for failure domain in KCP

[arshadd-b]

(🌱 )

What this PR does / why we need it:
This improves the coverage for failure domain in KCP

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #11602

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[arshadd-b]

Hi @fabriziopandini
I have noticed that in control_plane.go file there are no test cases for these functions
https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/control_plane.go#L325
https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/control_plane.go#L355
This PR doesn't cover these , Is it expected to cover these as well ?
I can raise a different PR covering these functions
Thanks

[chrischdi]

/ok-to-test

[nrb]

/area testing

[nrb]

The description here could be a little clearer. I think this test is trying to incur an error because the cluster requires 3 failure domains, but only has a machine in one of them, is that correct?

[arshadd-b]

Actually this test is returing error when we are trying to get infra resources
here https://github.com/kubernetes-sigs/cluster-api/blob/main/controlplane/kubeadm/internal/control_plane.go#L98

I have changed the description accordingly
0afe08d#diff-6edc995af12adcf728e5d1f3e6636db254b986fadea00df0c777ed89343f8899R184

Thanks

[nrb]

Thanks for adding tests! Left a few suggestions.