-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kueue-viz templates in helm charts #3852
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a79250b
to
e7546f3
Compare
@akram please try to make the initial PR minimal, we will add the needed parameters and functionalities in follow ups. |
42b487d
to
4a993a9
Compare
/hold for #3849 |
4a993a9
to
15be32a
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akram The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
That was more of a directional comment as it was getting large-ish as a draft, but I'm ok in the current form. Another thing is that we tend to first provide the config yamls, and then derive the helm charts based on them, so we could follow the pattern here too. PTAL at the visibility configs or prometheus, which are then part of the installable opt-in release artifacts: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.10.0. While making them release artifacts would be probably the next step I would like to follow the same pattern. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds kueue-viz helm charts allowing installation of kueue-viz using helm
Which issue(s) this PR fixes:
Fixes #3853
Special notes for your reviewer:
Does this PR introduce a user-facing change?