Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kueue-viz templates in helm charts #3852

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akram
Copy link
Contributor

@akram akram commented Dec 16, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds kueue-viz helm charts allowing installation of kueue-viz using helm

Which issue(s) this PR fixes:

Fixes #3853

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds kueue-viz helm charts allowing installation of kueue-viz using helm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2024
@akram akram marked this pull request as draft December 16, 2024 08:17
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2024
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 15be32a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/677e48f424e77a00081f32b8
😎 Deploy Preview https://deploy-preview-3852--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akram akram force-pushed the kueue-viz-helm-charts branch 5 times, most recently from a79250b to e7546f3 Compare December 16, 2024 08:53
@mimowo
Copy link
Contributor

mimowo commented Dec 16, 2024

@akram please try to make the initial PR minimal, we will add the needed parameters and functionalities in follow ups.

@akram akram force-pushed the kueue-viz-helm-charts branch 2 times, most recently from 42b487d to 4a993a9 Compare December 16, 2024 15:52
@mbobrovskyi
Copy link
Contributor

/hold for #3849

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@akram akram force-pushed the kueue-viz-helm-charts branch from 4a993a9 to 15be32a Compare January 8, 2025 09:44
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akram
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mimowo
Copy link
Contributor

mimowo commented Jan 8, 2025

/hold for #3849

/hold cancel
As the PR is merged and the images are already published in https://us-central1-docker.pkg.dev/k8s-staging-images/kueue

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@mimowo
Copy link
Contributor

mimowo commented Jan 8, 2025

@akram please try to make the initial PR minimal, we will add the needed parameters and functionalities in follow ups.

That was more of a directional comment as it was getting large-ish as a draft, but I'm ok in the current form.

Another thing is that we tend to first provide the config yamls, and then derive the helm charts based on them, so we could follow the pattern here too. PTAL at the visibility configs or prometheus, which are then part of the installable opt-in release artifacts: https://github.com/kubernetes-sigs/kueue/releases/tag/v0.10.0.

While making them release artifacts would be probably the next step I would like to follow the same pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kueue-viz templates in helm charts
4 participants