Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosi-driver-sample: added sample driver to image-pushing #34204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cosi-driver-sample: added sample driver to image-pushing #34204

wants to merge 1 commit into from

Conversation

shanduur
Copy link
Member

COSI Sample Driver was never built/released through the cloudbuild. Adding it to configs, so it can be built/pushed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@k8s-ci-robot k8s-ci-robot requested review from chases2 and dims January 23, 2025 18:54
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 23, 2025
@BlaineEXE
Copy link
Contributor

BlaineEXE commented Jan 23, 2025 •
edited
Loading

We need to run the script as well, which will generate some files.

Does the sample driver use main or master branch? If main, there is an additional script section that will need updated. [update: I see that it uses master, so I think this is the only script change needed.]

@shanduur shanduur force-pushed the feat/build-staging-cosi-driver-sample branch from 617da5d to a825ab2 Compare January 23, 2025 19:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@BlaineEXE
Copy link
Contributor

Looks good to me from the COSI KEP side of things!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BlaineEXE, shanduur
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shanduur
Copy link
Member Author

/assign thockin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@dims dims Awaiting requested review from dims

Assignees

@BlaineEXE BlaineEXE

@thockin thockin

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanduur @BlaineEXE @k8s-ci-robot @thockin