Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

block PRs to cri-api repo #34209

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

block PRs to cri-api repo #34209

wants to merge 1 commit into from

Conversation

SergeyKanzhelev
Copy link
Member

/sig node
/cc @samuelkarp @BenTheElder

the precedence is above for client-go.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 24, 2025
samuelkarp
samuelkarp approved these changes Jan 24, 2025
View reviewed changes
config/prow/plugins.yaml Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
@BenTheElder
Copy link
Member

FYI @kubernetes/sig-contributor-experience-leads @kubernetes/code-organization-project-admins

Given we have already done this for client-go, and this repo serves the same pattern as a staging repo:
/approve
Holding + no lgtm for further discussion / lazy consensus.
/hold

See Also: https://kubernetes.slack.com/archives/C01672LSZL0/p1737664265988589

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, samuelkarp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
This was referenced Jan 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@samuelkarp samuelkarp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergeyKanzhelev @BenTheElder @k8s-ci-robot @samuelkarp