feat: add resourceVersion for pod, svc and eps #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poor12
force-pushed
the
add-rv
branch
2 times, most recently
from
1bf9a43 to
f024694
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
- Coverage 33.60% 30.84% -2.77%
==========================================
Files 157 162 +5
Lines 18085 18823 +738
==========================================
- Hits 6078 5806 -272
- Misses 11485 12511 +1026
+ Partials 522 506 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Poor12
force-pushed
the
add-rv
branch
2 times, most recently
from
f4467d7 to
8823595
Compare
wy-lucky
reviewed
Jan 16, 2025
| @@ -114,14 +116,24 @@ func (m *PodMetrics) pods(ctx context.Context, options *metainternalversion.List | |||
| } | |||
|
|
|||
| namespace := genericapirequest.NamespaceValue(ctx) | |||
| pods, err := m.podLister.ByNamespace(namespace).List(labelSelector) | |||
| podsObj, err := m.podLister.ByNamespace(namespace).List(ctx, metav1.ListOptions{ | |||
| LabelSelector: labelSelector.String(), | |||
There was a problem hiding this comment.
It looks like we can add resourceVersion and filedSelector here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.