Fix speaker position for the AI generated voice

kubk · May 10, 2024 · 64686a0 · 64686a0
1 parent a2d5071
commit 64686a0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 9 deletions.
diff --git a/src/screens/deck-review/store/card-preview-store.ts b/src/screens/deck-review/store/card-preview-store.ts
@@ -114,23 +114,31 @@ export class CardPreviewStore implements LimitedCardUnderReviewStore {
     speak(removeAllTags(text), this.deckSpeakLocale);
   }
 
-  isCardSpeakerVisible(type: DeckSpeakFieldEnum) {
+
+  isCardSpeakerVisible(type: "front" | "back") {
+    if (!userStore.isSpeakingCardsEnabled) {
+      return false;
+    }
+
     if (this.voice) {
-      return type === "back";
+      return this.isOpened && type === this.deckSpeakField;
     }
 
     return (
       isSpeechSynthesisSupported &&
       this.isOpened &&
-      type === this.deckSpeakField &&
-      userStore.isSpeakingCardsEnabled
+      type === this.deckSpeakField
     );
   }
 
   get canSpeak() {
+    if (this.voice) {
+      return true;
+    }
+
     if (!isSpeechSynthesisSupported) {
       return false;
     }
-    return Boolean(this.voice || (this.deckSpeakLocale && this.deckSpeakField));
+    return Boolean(this.deckSpeakLocale && this.deckSpeakField);
   }
 }
diff --git a/src/screens/deck-review/store/card-under-review-store.ts b/src/screens/deck-review/store/card-under-review-store.ts
@@ -116,22 +116,29 @@ export class CardUnderReviewStore {
   }
 
   isCardSpeakerVisible(type: "front" | "back") {
+    if (!userStore.isSpeakingCardsEnabled) {
+      return false;
+    }
+
     if (this.voice) {
-      return type === "back";
+      return this.isOpened && type === this.deckSpeakField;
     }
 
     return (
       isSpeechSynthesisSupported &&
       this.isOpened &&
-      type === this.deckSpeakField &&
-      userStore.isSpeakingCardsEnabled
+      type === this.deckSpeakField
     );
   }
 
   get canSpeak() {
+    if (this.voice) {
+      return true;
+    }
+
     if (!isSpeechSynthesisSupported) {
       return false;
     }
-    return Boolean(this.voice || (this.deckSpeakLocale && this.deckSpeakField));
+    return Boolean(this.deckSpeakLocale && this.deckSpeakField);
   }
 }