Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow literals containig a colon not followed by space or newline #27

Closed
wants to merge 1 commit into from
Closed

allow literals containig a colon not followed by space or newline #27

wants to merge 1 commit into from

Conversation

freylax
Copy link

@freylax freylax commented Oct 8, 2023

This is a proposed fix for the issue:
Error when parsing value with colon (:) #18

@kubkon
Copy link
Owner

kubkon commented Jan 15, 2024

Can you rebase on main please?

@gwenzek gwenzek mentioned this pull request Nov 21, 2024
Merged
lunjon pushed a commit to lunjon/zig-yaml that referenced this pull request Nov 22, 2024
@lundholmx
fix: support colon in unquoted strings
1ec1b63 
Fix originally implemented by @freylax in kubkon#27
so credits should go that user.

However, since the author hasn't replied I thought
I'd open a new PR for this so we can merge it.

Also fixes the tests in main.
@lunjon lunjon mentioned this pull request Nov 22, 2024
Merged
lunjon added a commit to lunjon/zig-yaml that referenced this pull request Nov 22, 2024
@lunjon
fix: support colon in unquoted strings
80336db 
Fix originally implemented by @freylax in kubkon#27
so credits should go that user.

However, since the author hasn't replied I thought
I'd open a new PR for this so we can merge it.

Also fixes the tests in main.
lunjon added a commit to lunjon/zig-yaml that referenced this pull request Nov 22, 2024
@lunjon
fix: support colon in unquoted strings
9060246 
Fix originally implemented by @freylax in kubkon#27
so credits should go that user.

However, since the author hasn't replied I thought
I'd open a new PR for this so we can merge it.

Also fixes the tests in main.
@kubkon
Copy link
Owner

kubkon commented Dec 20, 2024

I believe #44 implemented this so I'll go ahead and close this PR. Feel free to reopen if I'm mistaken though!

@kubkon kubkon closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freylax @kubkon