-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add queryId
to CompiledQuery
to allow async communication between more components.
#176
base: v0.28
Are you sure you want to change the base?
add queryId
to CompiledQuery
to allow async communication between more components.
#176
Conversation
6790982
to
3a9d03f
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for continuing to update this branch @igalklebanov What do you think of this PR @koskimas? Are you going to merge it? This issue has been open for 2 years. I understand not wanting to break things, because it will be a pain to deal with. I am an open source maintainer, I get it. But serious projects really need this. It is essentially broken already to me, in its current state. Because my services are doing this constantly and I don't really have a good way to deal with it in Kysely. I feel backed into a corner. I have spent the past two weeks gathering data to try to fix this. I came up with this graph (query duation): And it is very symetrical with this graph (available connections): That causes downtime. I need to cancel queries after a timeout. I am planning to try some postgres workarounds, like using |
5269cd2
to
5d38c1b
Compare
a84367a
to
124c0dc
Compare
b2b78db
to
ae5cb1e
Compare
fcf13b9
to
471ef40
Compare
471ef40
to
19e5f43
Compare
b9b80bc
to
f75bc1e
Compare
e32bb7f
to
ca11632
Compare
19e5f43
to
29e5cb5
Compare
Open in Stackblitz • kysely_koa_example
commit: |
8da42a4
to
7300455
Compare
... ...
7300455
to
09c9294
Compare
does what #173 tried to achieve, but in a simpler way as suggested by @koskimas.