Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add queryId to CompiledQuery to allow async communication between more components. #176

Open
wants to merge 2 commits into
base: v0.28
Choose a base branch
from

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Sep 27, 2022

does what #173 tried to achieve, but in a simpler way as suggested by @koskimas.

@igalklebanov igalklebanov added the enhancement New feature or request label Sep 27, 2022
@igalklebanov igalklebanov requested a review from koskimas October 9, 2022 17:11
@igalklebanov igalklebanov added custom plugin Related to a custom plugin custom dialect Related to a custom dialect labels Oct 12, 2022
@koskimas koskimas force-pushed the master branch 2 times, most recently from 6790982 to 3a9d03f Compare September 28, 2023 05:33
@koskimas koskimas added the breaking change Includes breaking changes label Jan 6, 2024
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 4:38pm

@alexgleason
Copy link
Contributor

Thank you for continuing to update this branch @igalklebanov

What do you think of this PR @koskimas? Are you going to merge it? This issue has been open for 2 years. I understand not wanting to break things, because it will be a pain to deal with. I am an open source maintainer, I get it. But serious projects really need this. It is essentially broken already to me, in its current state. Because my services are doing this constantly and I don't really have a good way to deal with it in Kysely. I feel backed into a corner.

image

I have spent the past two weeks gathering data to try to fix this. I came up with this graph (query duation):

image

And it is very symetrical with this graph (available connections):

image

That causes downtime. I need to cancel queries after a timeout.

I am planning to try some postgres workarounds, like using set statement_timeout in a transaction. But that is a hack. I would really like a real solution. Thank you.

Copy link

pkg-pr-new bot commented Jan 26, 2025

Open in Stackblitzkysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@176

commit: f016590

@igalklebanov igalklebanov added built-in dialect Related to a built-in dialect built-in plugin Related to a built-in plugin labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes breaking changes built-in dialect Related to a built-in dialect built-in plugin Related to a built-in plugin custom dialect Related to a custom dialect custom plugin Related to a custom plugin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants