Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote/client: fallback to telnet when microcom is not available #1412

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

NickCao
Copy link
Contributor

@NickCao NickCao commented May 23, 2024

microcom is generally not available on rpm based distributions[1], making it hard to setup labgrid client on them.

[1] https://repology.org/project/microcom/versions

Description

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
    Tested the telnet code path in a fedora container.
  • Man pages have been regenerated

Sorry, something went wrong.

@sjg20
Copy link
Contributor

sjg20 commented May 23, 2024

See also this:

#1400

I was going to take a look at implementing something internal...but if you have time/inclintation to do it, PLMK

@jluebbe
Copy link
Member

jluebbe commented May 23, 2024

This workaround is not really invasive, so I'd be inclined to merge it. @Emantor @Bastian-Krause?

Emantor
Emantor previously approved these changes May 28, 2024
@sjg20
Copy link
Contributor

sjg20 commented Jun 10, 2024

Hi again,

I implemented a simple internal terminal here:

3f6d723

labgrid/remote/client.py Outdated Show resolved Hide resolved
@Emantor
Copy link
Member

Emantor commented Jun 17, 2024

Please squash the fix commit and rebase, this should also fix the DCO error and this should be ready to merge 👍

@Emantor Emantor added needs author info Requires more information from the PR/Issue author needs rebase Needs a rebase onto the master branch, maintainter could probably not push to submitter branch. labels Jun 17, 2024
@NickCao
Copy link
Contributor Author

NickCao commented Jun 17, 2024

Please squash the fix commit and rebase, this should also fix the DCO error and this should be ready to merge 👍

Done.

Emantor
Emantor previously approved these changes Jun 18, 2024
microcom is generally not available on rpm based distributions[1],
making it hard to setup labgrid client on them.

[1] https://repology.org/project/microcom/versions

Signed-off-by: Nick Cao <[email protected]>
[[email protected]: rebased, added CHANGES.rst entry]
Signed-off-by: Rouven Czerwinski <[email protected]>
@Emantor Emantor added enhancement and removed needs author info Requires more information from the PR/Issue author needs rebase Needs a rebase onto the master branch, maintainter could probably not push to submitter branch. labels Jun 26, 2024
@Emantor Emantor merged commit b6ec6f1 into labgrid-project:master Jun 26, 2024
9 checks passed
@NickCao NickCao deleted the telnet branch June 26, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants