Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor STARK for small fields #945

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Conversation

ColoCarletti
Copy link
Contributor

@ColoCarletti ColoCarletti commented Nov 29, 2024

Refactor STARK for small fields

This PR refactors the Air and TransitionConstraints traits to make the STARKs protocol compatible with small fields and their extensions.

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization

@ColoCarletti ColoCarletti requested a review from a team as a code owner November 29, 2024 18:58
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.14%. Comparing base (7b5a638) to head (605149d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   71.12%   71.14%   +0.02%     
==========================================
  Files         153      153              
  Lines       33101    33129      +28     
==========================================
+ Hits        23542    23570      +28     
  Misses       9559     9559              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@entropidelic entropidelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! really liked the TransitionEvaluationContext solution

@entropidelic entropidelic added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 2ce8b2e Dec 20, 2024
8 checks passed
@entropidelic entropidelic deleted the fix_stark_for_small_fields branch December 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants