Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed URL encoding of dataset_name #1035

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Removed URL encoding of dataset_name #1035

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
245b4c4
fix(client): Corrected dataset_name encoding
Dec 11, 2024
b1afc36
fix(client): Removed URL encoding of dataset_name
Dec 11, 2024
b6152c9
Merge branch 'main' into main
DeerShark Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions langfuse/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def get_dataset(
page = 1
while True:
new_items = self.client.dataset_items.list(
dataset_name=self._url_encode(name),
dataset_name=name,
page=page,
limit=fetch_items_page_size,
)
Expand Down Expand Up @@ -443,7 +443,7 @@ def get_dataset_runs(
try:
self.log.debug("Getting dataset runs")
return self.client.datasets.get_runs(
dataset_name=self._url_encode(dataset_name), page=page, limit=limit
dataset_name=dataset_name, page=page, limit=limit
)
except Exception as e:
handle_fern_exception(e)
Expand All @@ -468,8 +468,8 @@ def get_dataset_run(
f"Getting dataset runs for dataset {dataset_name} and run {dataset_run_name}"
)
return self.client.datasets.get_run(
dataset_name=self._url_encode(dataset_name),
run_name=self._url_encode(dataset_run_name),
dataset_name=dataset_name,
run_name=dataset_run_name,
)
except Exception as e:
handle_fern_exception(e)
Expand Down Expand Up @@ -1204,7 +1204,7 @@ def _fetch_prompt_and_update_cache(
)
def fetch_prompts():
return self.client.prompts.get(
self._url_encode(name),
name,
version=version,
label=label,
request_options={
Expand Down