-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate domain ts #856
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
The changes in langfuse/client.py
focus on deprecating the start_time
argument and replacing it with an instance attribute self.start_time
.
- Deprecated
start_time
argument inStatefulGenerationClient
,StatefulSpanClient
, andStatefulTraceClient
constructors. - Updated
update
andend
methods to useself.start_time
instead of passingstart_time
as an argument. - Marked
start_time
as deprecated in the docstrings of affected methods. - Ensured consistency in handling start times across the API.
- Thorough testing is required to avoid unintended side effects or breaking changes.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disclaimer: Experimental PR review
PR Summary
(updates since last review)
This PR introduces significant changes across the Langfuse Python SDK, focusing on improving functionality, error handling, and integration with various LLM frameworks. Here's a summary of the key changes:
- Enhanced LlamaIndex integration with new instrumentation capabilities and event handling.
- Improved OpenAI integration with support for newer API features and better error handling.
- Refactored error parsing and logging mechanisms for better diagnostics.
- Updated Langchain callback handler with new features and improved tracing.
- Significant version bump from 2.43.3 to 2.52.2, indicating multiple feature additions.
Key points to consider:
- The new LlamaIndex instrumentation (
LlamaIndexInstrumentor
) provides detailed tracing of LlamaIndex operations. - Error handling has been centralized with the new
parse_error.py
, improving consistency in error reporting. - The OpenAI integration now supports newer features like beta chat completions and structured output parsing.
- Prompt caching and management have been improved with the introduction of
PromptCacheRefreshConsumer
andPromptCacheTaskManager
. - Extensive test coverage has been added for new features, particularly for LlamaIndex instrumentation and OpenAI streaming.
157 file(s) reviewed, 73 comment(s)
Edit PR Review Bot Settings | Greptile
No description provided.