Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, just a small fix: without this, mypy doesn't consider langfuse's typing.
Given the following test file
with this change, mypy looks like this:
without this change (with the latest langfuse version), it looks like this:
I see there is some discussion already in langfuse/langfuse#2169, but it got stalled.
It is true that if I just run
mypy
on this repository, there are many complaints:So it would require a big effort to fix the whole library for mypy, but on the other hand, it's a shame that currently, any project that uses
@observe
is losing type safety, which can be fixed by this change.As a hot fix, without this change, having this wrapper in our code repository around the langfuse's observer seems like a way to go, but it's not a great solution: