Vec discount fix #27
Merged
Vec discount fix #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great @galatolofederico, thanks a lot for catching this bug! I'll ask for a small change: could you add one line about this PR in CHANGELOG.md explaining the fix and ending with your GitHub handle ? This makes it easy to keep track of what changed and when it did. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if I am opening so many PRs 😅
There was i bug in the
td.discountfunction when using it in a vectorized environment. I fixed it and wrote a test that compute the discounted rewards of a replay coming from a non vectorized environment and the discounted rewards of a replay coming from a vectorized environment and check if they are the same.This PR is needed to make #26 work because my A2C implementation uses a vectorized environment