Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing GitHub CI and tests. #64

Merged
merged 8 commits into from
Dec 4, 2023
Merged

Fixing GitHub CI and tests. #64

merged 8 commits into from
Dec 4, 2023

Conversation

leojklarner
Copy link
Owner

@leojklarner leojklarner commented Dec 4, 2023

Reference Issues/PRs

N/A

What does this implement/fix? Explain your changes

The current GitHub CI workflows used an outdated version of Ubuntu, meaning that they never executed. This updates the CI scripts and fixes some small black/isort issues.

What testing did you do to verify the changes in this PR?

N/A

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./gauche/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/kernels/test_graph_kernels.py)
  • Checked for style issues by running black . and isort .

@leojklarner leojklarner requested a review from Ryan-Rhys December 4, 2023 00:32
Copy link
Collaborator

@Ryan-Rhys Ryan-Rhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leojklarner leojklarner merged commit 90ac4a1 into main Dec 4, 2023
8 checks passed
@leojklarner leojklarner deleted the fixing_ci branch December 4, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants