Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nvidia/xid,sxid/dmesg): add dmesg log line matcher, xid/sxid extractor #333

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

gyuho
Copy link
Collaborator

@gyuho gyuho commented Jan 25, 2025

For #321.

@gyuho gyuho self-assigned this Jan 25, 2025
@gyuho gyuho added this to the v0.4.0 milestone Jan 25, 2025
Signed-off-by: Gyuho Lee <[email protected]>
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 21.26%. Comparing base (d24c32c) to head (d5d30f6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onents/accelerator/nvidia/query/xid/dmesg/dmesg.go 88.46% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   21.11%   21.26%   +0.15%     
==========================================
  Files         298      300       +2     
  Lines       27037    27089      +52     
==========================================
+ Hits         5708     5760      +52     
+ Misses      20686    20685       -1     
- Partials      643      644       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho gyuho changed the title feat(nvidia/xid/dmesg): add dmesg log line matcher, xid extractor feat(nvidia/xid,sxid/dmesg): add dmesg log line matcher, xid/sxid extractor Jan 25, 2025
Signed-off-by: Gyuho Lee <[email protected]>
Copy link
Collaborator

@eahydra eahydra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gyuho gyuho merged commit 02d1814 into main Jan 25, 2025
6 checks passed
@gyuho gyuho deleted the xid-sxid-dmesg-helper branch January 25, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants