Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL [WIP] #1596

Closed
wants to merge 1 commit into from
Closed

Fix RTL [WIP] #1596

wants to merge 1 commit into from

Conversation

tdelmas
Copy link
Collaborator

@tdelmas tdelmas commented Nov 8, 2023

Fix #1595

@tdelmas tdelmas changed the title Fix RTL Fix RTL [WIP] Nov 8, 2023
@yarons
Copy link
Contributor

yarons commented Nov 8, 2023

I did inspect the HTML just to see that the direction attribute in the HTML tag was set to ltr (explicitly), changed it to rtl manually: problem solved, we already have all the CSS rules to apply LTR when the flipping is unnecessary (code blocks) so changing this attribute should be they way to go in case all those other modifications we've done in the past still apply.

Thank you!

@tdelmas
Copy link
Collaborator Author

tdelmas commented Nov 9, 2023

Yes, that was also my diagnostic. Something changed in the format of the configuration or in Hugo, because the settings is correct in the language file (rtl).
I'll need a little more time to figure it out, but I will !

Thank you for your help and your patience @yarons

@yarons
Copy link
Contributor

yarons commented Nov 9, 2023

I'm not sure if there's a way for me to trigger a netlify build but if there is I'd love to help.

@tdelmas
Copy link
Collaborator Author

tdelmas commented Nov 9, 2023

@yarons you can build locally directly with Hugo (you need to use the correct version with extended). For netlify you need to configure it for your GitHub fork.

Also, if you have the solution you can create a PR here and it will automatically create the preview.

@tdelmas tdelmas closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTL is broken
2 participants