Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/vs19 nuget compatibility #1160

Open
wants to merge 2 commits into
base: 1.9.x
Choose a base branch
from
Open

Fix/vs19 nuget compatibility #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7975d
Building NuGet using VS19
COM8 Jan 11, 2025
4f51f71
Changed the NuGet author to "Fabian Sauter"
COM8 Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
package-windows-latest:
runs-on: windows-latest
runs-on: windows-2019
steps:
- name: Set version based on input
if: ${{ inputs.version }}
Expand All @@ -32,7 +32,7 @@ jobs:
uses: nuget/setup-nuget@v1
- name: "[Release_x86] Build & Install"
env:
CMAKE_GENERATOR: "Visual Studio 17 2022"
CMAKE_GENERATOR: "Visual Studio 16 2019"
uses: ashutoshvarma/action-cmake-build@master
with:
build-dir: ${{github.workspace}}/build
Expand All @@ -49,7 +49,7 @@ jobs:
run: rm -r -fo ${{github.workspace}}/build
- name: "[Debug_x86] Build & Install"
env:
CMAKE_GENERATOR: "Visual Studio 17 2022"
CMAKE_GENERATOR: "Visual Studio 16 2019"
uses: ashutoshvarma/action-cmake-build@master
with:
build-dir: ${{github.workspace}}/build
Expand All @@ -66,7 +66,7 @@ jobs:
run: rm -r -fo ${{github.workspace}}/build
- name: "[Release_x64] Build & Install"
env:
CMAKE_GENERATOR: "Visual Studio 17 2022"
CMAKE_GENERATOR: "Visual Studio 16 2019"
uses: ashutoshvarma/action-cmake-build@master
with:
build-dir: ${{github.workspace}}/build
Expand All @@ -83,7 +83,7 @@ jobs:
run: rm -r -fo ${{github.workspace}}/build
- name: "[Debug_x64] Build & Install"
env:
CMAKE_GENERATOR: "Visual Studio 17 2022"
CMAKE_GENERATOR: "Visual Studio 16 2019"
uses: ashutoshvarma/action-cmake-build@master
with:
build-dir: ${{github.workspace}}/build
Expand Down
2 changes: 1 addition & 1 deletion nuget/libcpr.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<id>libcpr</id>
<version>$VERSION$</version>
<title>C++ Requests: Curl for People</title>
<authors>Simon Berger</authors>
<authors>Fabian Sauter</authors>
<owners>Fabian Sauter, Kilian Traub, many other libcpr contributors</owners>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<license type="expression">MIT</license>
Expand Down
Loading