-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce libp2p-webrtc-websys behind webrtc-websys feature flag. #5819
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Darius! LGTM.
cc @elenaf9 @guillaumemichel wdyt of releasing 55.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Darius! LGTM. cc @elenaf9 @guillaumemichel wdyt of releasing 55.1?
Sounds good to me.
I just noticed that we never released libp2p-webrtc
as stable, even though it was implemented way before libp2p-webrtc-websys
.
Should we also move libp2p-webrtc
to stable, and include it in the patch release?
Description
With the promotion of
libp2p-webrtc-websys
to a non-alpha/stable release, we should also re-export it as apart oflibp2p
with it being behind awebrtc-websys
feature.Notes & open questions
Change checklist