Improved code structure (backend/getIp.php) #670
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the overall code structure of backend/getIp.php. Really suggest going with a more oop based code tbh but I guess this works. ㄟ( ▔, ▔ )ㄏ
|
hey @Mespeet ! thank you for the really more readable code. i would like to merge it, but would like to know if this would need any minimum php version. i know @adolfintel still wants to support older php versions so far, so your change should not break anyones installation where still older php is used. |
sstidl
requested changes
Dec 29, 2024
| * Fetch the client's IP address. | ||
| * @return string | ||
| */ | ||
| function getClientIp(): string { |
There was a problem hiding this comment.
why move this from getIP_util.php here? and also this is not the same code as there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the overall code structure of backend/getIp.php.
Really suggest going with a more oop based code tbh but I guess this works. ㄟ( ▔, ▔ )ㄏ