Skip to content

Commit

Permalink
Don't enable serde's std feature
Browse files Browse the repository at this point in the history
When we use the `serde?/std` syntax for the feature, we end up
with a public dependency on `serde` even when it isn't enabled
or used. It isn't compiled, but it feels wrong. We don't need
the `std` feature from `serde`, so no need to enable it and
someone that does will already have it enabled.
  • Loading branch information
waywardmonkeys committed Dec 21, 2024
1 parent cb17d46 commit 1eaddb7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ This release has an [MSRV][] of 1.82.

* Make color parsing case insensitive. ([#109][] by [@raphlinus][])

### Changed

* Don't enable `serde`'s `std` feature when enabling our `std` feature. ([#108][] by @waywardmonkeys][])

## [0.2.0][] (2024-12-17)

This release has an [MSRV][] of 1.82.
Expand Down Expand Up @@ -78,7 +82,11 @@ This is the initial release.
[#86]: https://github.com/linebender/color/pull/86
[#92]: https://github.com/linebender/color/pull/92
[#100]: https://github.com/linebender/color/pull/100
<<<<<<< HEAD
[#109]: https://github.com/linebender/color/pull/109
=======
[#108]: https://github.com/linebender/color/pull/108
>>>>>>> 1cd88aa (Don't enable serde's `std` feature)
[Unreleased]: https://github.com/linebender/color/compare/v0.2.0...HEAD
[0.2.0]: https://github.com/linebender/color/releases/tag/v0.2.0
Expand Down
2 changes: 1 addition & 1 deletion color/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ targets = []

[features]
default = ["std"]
std = ["serde?/std"]
std = []
libm = ["dep:libm"]
bytemuck = ["dep:bytemuck"]
serde = ["dep:serde"]
Expand Down

0 comments on commit 1eaddb7

Please sign in to comment.