feat(multicluster): propagate service labels to endpoints #13583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Kubernetes creates endpoints for a service, it propagates the labels from the parent service to the endpoints, allowing these labels to be used for discovery. When using Linkerd mirrored endpoints, this ability was lost until now. This change simply mimics the vanilla Kubernetes behavior by propagating the remote service labels to mirror endpoints. https://github.com/kubernetes/kubernetes/blob/a716ea756d87f60900dbbb500fc27ae30f7bd384/pkg/controller/endpoint/endpoints_controller.go#L506 Signed-off-by: Maxime Brunet <[email protected]>
alpeb
approved these changes
Jan 23, 2025
Comment on lines
+29
to
+31
| t.Helper() | ||
| t.Run(tc.description, func(t *testing.T) { | ||
| t.Helper() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Kubernetes creates endpoints for a service, it propagates the labels from the parent service to the endpoints, allowing these labels to be used for discovery. When using Linkerd mirrored endpoints, this ability was lost until now.
This change simply mimics the vanilla Kubernetes behavior by propagating the remote service labels to mirror endpoints.
kubernetes/kubernetes@
a716ea7/pkg/controller/endpoint/endpoints_controller.go#L506The tests were updated to include a custom label on the services and validate its propagation to the endpoints