-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pyinstaller #19
Feat/pyinstaller #19
Conversation
Have you tested whether pyinstaller can work on this? |
Yes, the exe works well. I disablesd the output in console, I think users may not need it. |
The updator may have some unknown problem, but the updator.py should be modified anyway. Maybe I will fix it in another pr. |
For executables the old updater doesn't work because it is based on git |
Maybe we can just remove git update logic when building for executables. |
It seems that I didn't solve the dependency well, currently the exe only works under the dir with canvas_mgr.py and etc. I will try to fix it. |
Also we need to migrate some arguments from uvicorn to the executables, eg. the port and base_url |
I think we can remove the updater support. It is not very helpful and needs git dependency. |
… into feat/pyinstaller
do not merge until everything is set |
Please fix the build error. |
I think we should first merge it to the dev branch otherwise current users will be affected |
start.py
Outdated
if usr_host == "": | ||
usr_host = "localhost" | ||
if usr_port == "": | ||
usr_port = 9283 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not write duplicate code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
This pr modified canvas_app s.t. the code can be packed with pyinstaller