Fix warnings introduced in cargo clippy 1.84.0 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is inspired by the clippy lint unnecessary_map_or[1] added in version 1.84.0. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or Signed-off-by: Leonard Göhrs <[email protected]>
This change is inspired by the clippy lint unnecessary_map_or[1] added in version 1.84.0. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or Signed-off-by: Leonard Göhrs <[email protected]>
This is inspired by cargo lint needless_lifetimes[1] which has started complaining about this occurrence starting with version 1.84.0. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes Signed-off-by: Leonard Göhrs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cargo clippycommand has learned new tricks in version 1.84.0 that was released yesterday, causing our CI to fail.Fix those so our CI jobs are nice and green again.