Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dock cannot hide clipboard in non special effects mode #159

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Apr 29, 2024

The interval between displaying and hiding operations must be greater than 300ms

Log:

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • showAni函数中,m_trickTimer的起始时间为300毫秒,但未指定计时结束信号触发时槽函数的执行。可能导致计时结束时仍然没有触发buttonPress信号连接的槽函数。
  • m_trickTimershowAnihideAni函数中被添加,但没有在类中声明,可能导致在未访问过m_trickTimer时出现悬空指针错误。
  • m_trickTimer的命名不够直观,建议使用更具描述性的名称,如showingAnimationTimer
  • initUI函数中的m_trickTimer设置为单次触发,但在类中没有看到其停止信号的连接或处理逻辑,可能导致计时结束后的行为不符合预期。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The interval between displaying and hiding operations must be greater than 300ms

Issue: linuxdeepin/developer-center#8309
@mhduiy
Copy link
Contributor Author

mhduiy commented Apr 29, 2024

/merge

@deepin-bot deepin-bot bot merged commit e262a30 into linuxdeepin:master Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants