Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when dock is set to always hide, the window size is incorrect #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zsien
Copy link

@zsien zsien commented May 10, 2024

使用 availableGeometry

Issues: linuxdeepin/developer-center#8501

@zsien zsien requested a review from a team May 10, 2024 08:09
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien force-pushed the zs/fix/windowsize branch from fb3bd27 to 16463a3 Compare May 10, 2024 09:42
Copy link

github-actions bot commented May 10, 2024

TAG Bot

TAG: 6.0.10
EXISTED: no
DISTRIBUTION: unstable

@zsien
Copy link
Author

zsien commented May 10, 2024

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1403
PrNumber: 1403
PrBranch: auto-integration-9030632065

zsien added 2 commits May 11, 2024 16:59
@zsien zsien force-pushed the zs/fix/windowsize branch from 525fd3b to f7e067a Compare May 11, 2024 09:00
@zsien
Copy link
Author

zsien commented May 11, 2024

/integrate

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • primaryGeometryChanged函数中,传入的rect参数应该是一个const QRect &rect对象,而不是一个空对象。
  • primaryGeometryChanged函数的注释应该更新以反映其新的功能,例如,它现在处理的是整个屏幕的可用大小变化。
  • 删除了geometryChanged函数,但是没有看到对应的功能或逻辑是否迁移到了primaryGeometryChanged中。如果迁移了,应该更新注释或文档。
  • adjustPosition函数中,rect参数的命名应该遵循其他参数的命名,例如const QRect &rect,而不是QRect rect
  • adjustPosition函数的注释应该更新以反映其新的功能,例如,它现在根据屏幕的可用大小和dock的位置来调整窗口的大小。
  • 移除了getDisplayScreen函数,但是没有看到相关的使用或实现,如果这个函数确实不再需要,应该在提交信息中说明原因。
  • 删除了m_displayInter变量的定义,但是没有看到对应的逻辑或功能是否迁移到了其他部分。如果迁移了,应该更新注释或文档。

是否建议立即修改:

代码审查建议立即修改,因为这些变化可能会影响到程序的功能、可读性和一致性。特别是对于函数和变量的移除,需要确保它们不会破坏现有的代码逻辑。同时,更新注释和文档可以帮助其他开发者更好地理解代码的目的和行为。

@zsien
Copy link
Author

zsien commented May 13, 2024

/integrate

1 similar comment
@zsien
Copy link
Author

zsien commented May 13, 2024

/integrate

@tsic404
Copy link
Contributor

tsic404 commented May 13, 2024

dock 非一直显示下,后面应该要取消独占区域

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants