Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the cloud icon is displayed in black #1959

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

xionglinlin
Copy link
Contributor

Change the SVG icon to a DCI icon.

Log: ui display

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link

deepin-bot bot commented Dec 19, 2024

TAG Bot

New tag: 6.1.1
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1964

Change the SVG icon to a DCI icon.

Log: ui display
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. deepinid.qrc文件中,新增了一个<qresource>标签,但未提供对应的<file>标签内容,需要确认是否遗漏了文件路径。

  2. deepinid.qrc文件中,删除了<file>icons/dcc_cloud_logo.svg</file>,但新增了一个<file>icons/dcc_cloud_logo.dci</file>。需要确认这两个文件是否是同一个文件的不同格式,如果是,是否需要更新相关的引用路径。

  3. LoginPage.qml文件中,将Image标签替换为了D.DciIcon标签,但未提供D.DciIcon的具体实现。需要确认D.DciIcon是否是一个有效的组件,并且是否已经正确地实现了所需的功能。

  4. LoginPage.qml文件中,Image标签的fillMode属性被注释掉了,如果这是有意为之,需要确认是否有其他方式来处理图像填充模式。

  5. LoginPage.qml文件中,Image标签的clip属性被设置为true,但未提供clip的具体含义。需要确认clip属性是否正确地实现了图像裁剪功能。

  6. LoginPage.qml文件中,Image标签的source属性被设置为"qrc:/icons/deepin/builtin/icons/dcc_login_bg.svg",但未提供对应的文件路径。需要确认文件路径是否正确。

  7. LoginPage.qml文件中,D.DciIcon标签的name属性被设置为"dcc_cloud_logo",但未提供对应的D.DciIcon组件的实现。需要确认D.DciIcon组件是否已经正确地实现了所需的功能。

  8. LoginPage.qml文件中,D.DciIcon标签的anchors属性被设置为anchors.horizontalCenter: parent.horizontalCenteranchors.bottom: parent.bottom,但未提供parent的具体含义。需要确认parent是否已经正确地定义了父组件。

  9. LoginPage.qml文件中,D.DciIcon标签的fillMode属性被注释掉了,如果这是有意为之,需要确认是否有其他方式来处理图像填充模式。

  10. LoginPage.qml文件中,D.DciIcon标签的source属性被注释掉了,如果这是有意为之,需要确认是否有其他方式来设置图像源。

以上是代码审查的初步意见,需要根据具体情况进行进一步的确认和修改。

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 20, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit ee3485e into linuxdeepin:master Dec 20, 2024
15 of 18 checks passed
@xionglinlin xionglinlin deleted the fix/cloudicon branch January 15, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants