Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Click on clipboard quick item will trigger screenshot plugins too #227

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ArchieMeng
Copy link
Contributor

The message events were emitted on all the plugins. By typo maybe?

pms: BUG-295927
Log: Click on clipboard quick item will trigger screenshot plugins too

The message events were emitted on all the plugins. By typo maybe?

pms: BUG-295927
Log: Click on clipboard quick item will trigger screenshot plugins too
@ArchieMeng
Copy link
Contributor Author

/recheck

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tsic404
Copy link
Contributor

tsic404 commented Dec 20, 2024

/test all

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • foreach循环中使用了auto关键字,但未指定类型,建议明确指定类型以提高代码可读性。
  • foreach循环中添加了if条件判断,以避免不必要的消息发送,这是一个好的做法。

是否建议立即修改:

  • 否,当前提交的修改是合理的,没有发现需要立即修改的关键问题。但是,建议在未来的提交中明确指定foreach循环中的类型,以提高代码的可读性。

@ArchieMeng
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Dec 20, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 9e04fb0 into linuxdeepin:master Dec 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants