Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid url #124

Conversation

wyu71
Copy link
Contributor

@wyu71 wyu71 commented Dec 20, 2024

remove invalid url

Log: remove invalid url

remove invalid  url

Log: remove invalid  url
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 注释清理

    • 删除了关于UT环境搭建的注释,这有助于保持代码的整洁性。但是,如果这些注释对其他开发者理解项目配置有帮助,建议保留或更新到文档中。
  2. CMake版本要求

    • cmake_minimum_required(VERSION 3.9.5) 这一行指定了CMake的最低版本要求。确保项目中的所有依赖项和功能都支持这个版本。如果项目需要更高版本的CMake,应该更新这个版本号。
  3. 代码风格

    • 代码风格保持了一致性,没有发现明显的格式问题。
  4. 文档和注释

    • 考虑添加一些更详细的注释,特别是对于CMakeLists.txt文件,解释为什么需要特定的CMake版本,以及这个文件的作用和配置。
  5. 可读性

    • 文件中没有发现影响代码可读性的问题。

总体来说,这次提交的改动很小,主要是清理了一些注释。如果这些注释对项目理解有帮助,建议保留或更新到项目的文档中。同时,确保CMake版本符合项目需求,并保持代码风格的一致性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wyu71 wyu71 merged commit ffa0504 into linuxdeepin:transifex_update_68ed6160c4 Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants