Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize delay for show #331

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jeffshuai
Copy link

optimize delay for show

Log: delay for show

Bug: https://pms.uniontech.com/bug-view-283415.html

optimize delay for show

Log:  delay for show

Bug: https://pms.uniontech.com/bug-view-283415.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • set_forceGles 函数和 is_forceGles 函数的命名应遵循一致的命名规范,例如使用驼峰命名法。
  • get_wayland_status 函数中新增的逻辑可能会导致在 is_forceGles 返回 1 时返回 0,这可能不是预期的行为。
  • initializeGL 函数中的 GLSL 代码应该根据 is_forceGles 的返回值动态生成,而不是硬编码。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jeffshuai, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@jeffshuai
Copy link
Author

/merge

@deepin-bot deepin-bot bot merged commit 702a5c8 into linuxdeepin:release/eagle Dec 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants